Closed tkraak closed 7 years ago
@jescalan ... question ... this assumes the markdownPlugins
object in the form of:
const options = {
markdownPlugins: { emoji, toc, videoEmbed }
}
Is that ok as long as we document how plugins should be added to the object?
Why not have it as an array instead of an object?
I've been playing with trying to pass along plugin options as well, but can't get it.
Based on the markdown-it plugin docs, options need to be passed as a second argument, but I can't get the syntax right for passing it from app.js. I tried just manually adding options inside reshape-standard's index.js and it works (for one plugin, obviously).
When I try to use your suggested code @jescalan I get Error: TypeError: (intermediate value) is not a function
Realize this isn't a huge priority, but I'm trying to keep it moving.
My repo is here: https://github.com/sagecomm/reporter (will need to manually edit reshape-standard/index.js with changes in this PR)
@mwickett ... I should have my refactor pushed within 24 hours, which fixes the Error: TypeError: (intermediate value) is not a function
error.
Let's worry about plugin options after that. I'm eager to keep this moving as well 🐎 .
This is looking great so far! Looking forward to some tests 😁