search

resibots / libdynamixel

C++ interface to the dynamixel actuators
GNU General Public License v2.0
9 stars 15 forks source link

High-level interface for speed control of actuators #21

Closed dogoepp closed 7 years ago

dogoepp commented 7 years ago

This allows for easy an generic control of target speed for actuators both in joint and wheel mode. It has been tested for AX-12+, MX-64 and MX-28AT actuators.

Nonetheless, a review of the code by at least one of the teem members will be most appreciated.

fedeallocati commented 7 years ago

Hey, I think this looks really good, and the Protocol Specific Packets is a nice idea.

dogoepp commented 7 years ago

Hey Federico, Thanks a lot for the feedback. I'm flattered by your remark :-)

So, OK to merge for you ?

What about you @costashatz ?

costashatz commented 7 years ago

What about you @costashatz ?

If @fedeallocati says it is ok and you tested on actual hardware, it's ok for me too..

dogoepp commented 7 years ago

merging

dogoepp commented 7 years ago

Still, it would be nice if @jbmouret could check at least src/dynamixel/servos/protocol_specific_packets.hpp for general C++ soundness.