search

resibots / libdynamixel

C++ interface to the dynamixel actuators
GNU General Public License v2.0
9 stars 15 forks source link

add a little precision in ServoLimitError message #42

Closed elkhadiy closed 6 years ago

elkhadiy commented 6 years ago

issue #41

make it more explicit to users that didn't pay attention to the help that they have to give the angle value in radians

dogoepp commented 6 years ago

Hi @elkhadiy,

Thanks for taking time to look into this relevant issue. Maybe it might be better to switch everything to radians, since it's what is used in the whole API.

elkhadiy commented 6 years ago

yeah seems like a good idea, a git grep shows that you guys only seem to use values in deg extracted from the hardware's docs (I'm guessing)

dogoepp commented 6 years ago

Thanks a lot for your contribution. It seems all right but I need to test it before it goes into master, since it is used for experiments that can hardly afford a bug.

dogoepp commented 6 years ago

I just tested it, all goes well. Do you think that you could rebase your commit on master and fore push the your branch ?