search

resibots / libdynamixel

C++ interface to the dynamixel actuators
GNU General Public License v2.0
9 stars 15 forks source link

remove timeout parameter from open_serial #8

Closed dogoepp closed 8 years ago

dogoepp commented 8 years ago

The method open_serial could be called several times in the lifecycle of the class but we might not want to change the recieve timeout, nor reset it to the default value. Therefore, it is initialised by the constructor (isn't it cleaner anyway ?) and still accessible with a getter and a setter.

dogoepp commented 8 years ago

Any comment ?

costashatz commented 8 years ago

For me it's fine. @fedeallocati should have a bigger say in this..

fedeallocati commented 8 years ago

For me is fine too, I talked with Dorian about this yesterday El mar. 2, 2016 11:14 AM, "Konstantinos Chatzilygeroudis" < notifications@github.com> escribió:

For me it's fine. @fedeallocati https://github.com/fedeallocati should have a bigger say in this..

— Reply to this email directly or view it on GitHub https://github.com/resibots/libdynamixel/pull/8#issuecomment-191170181.

dogoepp commented 8 years ago

merging