Closed dogoepp closed 8 years ago
Any comment ?
For me it's fine. @fedeallocati should have a bigger say in this..
For me is fine too, I talked with Dorian about this yesterday El mar. 2, 2016 11:14 AM, "Konstantinos Chatzilygeroudis" < notifications@github.com> escribió:
For me it's fine. @fedeallocati https://github.com/fedeallocati should have a bigger say in this..
— Reply to this email directly or view it on GitHub https://github.com/resibots/libdynamixel/pull/8#issuecomment-191170181.
merging
The method open_serial could be called several times in the lifecycle of the class but we might not want to change the recieve timeout, nor reset it to the default value. Therefore, it is initialised by the constructor (isn't it cleaner anyway ?) and still accessible with a getter and a setter.