search

resilar / sqleet

SQLite3 encryption that sucks less
The Unlicense
372 stars 53 forks source link

SQLeet manifests itself as SQLite. Is it intentional? #28

Closed johnfound closed 4 years ago

johnfound commented 4 years ago

In SQLeet, the string on sqlite3_version and sqlite3_sourceid() returns the version and commit ID of the SQLite, not of SQLeet.

Is this behavior intentional? Is there a way for the application to check and display the version of SQLeet?

resilar commented 4 years ago

SQLite3 version number matches sqleet version as explained in README.md#Versioning-Scheme. The sourceid is more complicated, but I think the current behavior is acceptable (I'd still like to hear if this is an issue for someone's use case). After all, sqleet is an extension of SQLite3 the same way as the official SQLite Encryption Extension (SEE) which also does not modify the sourceid to my knowledge.

If version numbers are too inaccurate, then exposing sqleet commit hash somehow might be a good idea. However, I do not see an easy way to implement this without complicating the compilation/build process, so let's reconsidering this feature later if there is real demand for exact sqleet commit ids.

Closing, feel free to reopen if it feels necessary. Thanks for the feedback.