resilient-tech / india-compliance

Simple, yet powerful compliance solutions for Indian businesses
https://indiacompliance.app
GNU General Public License v3.0
151 stars 139 forks source link

Error on downloading GSTR2B #2721

Closed eskhool closed 2 days ago

eskhool commented 4 days ago

Information about bug

TypeError: PurchaseReconciliationTool.download_gstr() missing 1 required positional argument: 'company_gstin' Possible source of error: india_compliance (app)

App Versions

{
    "erpnext": "15.41.1",
    "frappe": "15.47.1",
    "hrms": "15.35.0",
    "india_compliance": "15.13.5",
    "payments": "0.0.1",
    "print_designer": "1.0.0-dev",
    "webshop": "0.0.1"
}

Route

Form/Purchase Reconciliation Tool/Purchase Reconciliation Tool

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 114, in application
    response = frappe.api.handle(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
           ^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/__init__.py", line 1781, in call
    return fn(*args, **newargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 336, in run_doc_method
    response = doc.run_method(method, **args)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 962, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1322, in composer
    return composed(self, method, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1304, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 959, in fn
    return method_object(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/india_compliance/india_compliance/gst_india/api_classes/taxpayer_base.py", line 43, in wrapper
    raise e
  File "apps/india_compliance/india_compliance/gst_india/api_classes/taxpayer_base.py", line 34, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
TypeError: PurchaseReconciliationTool.download_gstr() missing 1 required positional argument: 'company_gstin'

Request Data

{
    "type": "POST",
    "args": {
        "return_type": "GSTR2b",
        "date_range": "[\"2023-01-01\",\"2024-11-14\"]",
        "force": false,
        "gst_categories": null,
        "docs": "{\"name\":\"Purchase Reconciliation Tool\",\"owner\":\"Administrator\",\"modified\":\"2024-11-14 12:14:03.313853\",\"modified_by\":\"Administrator\",\"docstatus\":0,\"idx\":\"0\",\"company\":\"Prolific Engineering Technologies Private Limited\",\"include_ignored\":0,\"company_gstin\":\"All\",\"purchase_period\":\"Custom\",\"purchase_from_date\":\"2023-01-01\",\"purchase_to_date\":\"2024-11-14\",\"inward_supply_period\":\"Custom\",\"inward_supply_from_date\":\"2023-01-01\",\"inward_supply_to_date\":\"2024-11-14\",\"gst_return\":\"Both GSTR 2A & 2B\",\"is_modified\":0,\"reconciliation_data\":\"[]\",\"doctype\":\"Purchase Reconciliation Tool\",\"__onload\":{\"has_missing_2b_documents\":true},\"__last_sync_on\":\"2024-11-14T06:44:07.218Z\"}",
        "method": "download_gstr",
        "args": "{\"return_type\":\"GSTR2b\",\"date_range\":[\"2023-01-01\",\"2024-11-14\"],\"force\":false,\"gst_categories\":null}"
    },
    "headers": {},
    "error_handlers": {},
    "url": "/api/method/run_doc_method",
    "request_id": null
}

Response Data

{
    "exception": "TypeError: PurchaseReconciliationTool.download_gstr() missing 1 required positional argument: 'company_gstin'",
    "exc_type": "TypeError",
    "_exc_source": "india_compliance (app)"
}

Version

Frappe Framework: v15.47.1 (version-15)

ERPNext: v15.41.1 (version-15)

India Compliance: v15.13.5 (version-15)

Frappe HR: v15.35.0 (version-15)

Payments: v0.0.1 (develop)

Print Designer: v1.x.x-develop () (develop)

Webshop: v0.0.1 (develop)

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

Huly®: IC-2847

india-compliance-bot commented 2 days ago

:tada: This issue has been resolved in version 14.30.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

india-compliance-bot commented 2 days ago

:tada: This issue has been resolved in version 15.14.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: