resilient-tech / india-compliance

Simple, yet powerful compliance solutions for Indian businesses
https://indiacompliance.app
GNU General Public License v3.0
151 stars 139 forks source link

fix: validate hsn code for both e-waybill and e-invoice (backport #2732) #2735

Closed mergify[bot] closed 4 days ago

mergify[bot] commented 5 days ago

HSN Code needs to be validated in both e-Waybill and e-Invoice data. Currently, it is only validated in e-invoice. Frappe Support Ticket: https://support.frappe.io/helpdesk/tickets/25604

Huly®: IC-2858


This is an automatic backport of pull request #2732 done by Mergify.

mergify[bot] commented 5 days ago

Cherry-pick of bd679e6b6242c78416d8d2e2d2987528494985d8 has failed:

On branch mergify/bp/version-14-hotfix/pr-2732
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit bd679e6b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   india_compliance/gst_india/utils/e_invoice.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   india_compliance/gst_india/utils/transaction_data.py

Cherry-pick of e516a8f8698828af13094cd44c928a2420cf80e0 has failed:

On branch mergify/bp/version-14-hotfix/pr-2732
Your branch is ahead of 'origin/version-14-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit e516a8f8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   india_compliance/gst_india/overrides/sales_invoice.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   india_compliance/gst_india/overrides/purchase_invoice.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.13%. Comparing base (4abbc01) to head (507ac5d). Report is 10 commits behind head on version-14-hotfix.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735/graphs/tree.svg?width=650&height=150&src=pr&token=RBZLDO9SOL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech)](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech) ```diff @@ Coverage Diff @@ ## version-14-hotfix #2735 +/- ## ===================================================== - Coverage 61.13% 61.13% -0.01% ===================================================== Files 114 114 Lines 11115 11114 -1 ===================================================== - Hits 6795 6794 -1 Misses 4320 4320 ``` | [Files with missing lines](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech) | Coverage Δ | | |---|---|---| | [...ia\_compliance/gst\_india/overrides/sales\_invoice.py](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735?src=pr&el=tree&filepath=india_compliance%2Fgst_india%2Foverrides%2Fsales_invoice.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech#diff-aW5kaWFfY29tcGxpYW5jZS9nc3RfaW5kaWEvb3ZlcnJpZGVzL3NhbGVzX2ludm9pY2UucHk=) | `81.61% <100.00%> (ø)` | | | [india\_compliance/gst\_india/utils/e\_invoice.py](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735?src=pr&el=tree&filepath=india_compliance%2Fgst_india%2Futils%2Fe_invoice.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech#diff-aW5kaWFfY29tcGxpYW5jZS9nc3RfaW5kaWEvdXRpbHMvZV9pbnZvaWNlLnB5) | `74.24% <100.00%> (-0.24%)` | :arrow_down: | | [...dia\_compliance/gst\_india/utils/transaction\_data.py](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735?src=pr&el=tree&filepath=india_compliance%2Fgst_india%2Futils%2Ftransaction_data.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech#diff-aW5kaWFfY29tcGxpYW5jZS9nc3RfaW5kaWEvdXRpbHMvdHJhbnNhY3Rpb25fZGF0YS5weQ==) | `92.82% <100.00%> (+0.06%)` | :arrow_up: | [![Impacted file tree graph](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735/graphs/tree.svg?width=650&height=150&src=pr&token=RBZLDO9SOL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech)](https://app.codecov.io/gh/resilient-tech/india-compliance/pull/2735?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=resilient-tech)

🚨 Try these New Features:

india-compliance-bot commented 4 days ago

:tada: This PR is included in version 14.30.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: