search

resloved / i3

🔲 — Rounded i3-gaps
Other
277 stars 29 forks source link

Setting to turn off rounded corners when lone application #11

Closed vidarrio closed 4 years ago

vidarrio commented 4 years ago

Just like smart_gaps turns off gaps when there's a single application, have a setting that does the same but for rounded corners. Currently it looks pretty ugly with smart_gaps on.

resloved commented 4 years ago

When smart_gaps is enabled and there is only one window it won't round the window as of https://github.com/resloved/i3/commit/fa1cc457a01b939e162e94c5096e922faf954fc9

Close this issue if it's working as intended

vidarrio commented 4 years ago

Works great thanks, a minor thing is that maybe it shouldn't disable rounded corners if there are only floating windows, alternatively if a window is floating, but it doesn't matter much.

resloved commented 4 years ago

Hm, that makes sense to me. I just used the same logic that's used when determining if gaps should be removed. Now that I think of it removing the gaps wouldn't affect floating windows so they're never considered.

I'll see if it would be a simple fix.

resloved commented 4 years ago

Floating windows will still be rounded when smart_gaps is on and there is less then two (1 or 0) non-floating windows as of https://github.com/resloved/i3/commit/f3fffbaef26ac27cda3fe0516dcb27ad404404f0

I've never used smart_gaps before this, but I think this is the behavior that should be expected.

vidarrio commented 4 years ago

Thanks a lot, works perfectly!