resmio / widget

Our booking widget
1 stars 0 forks source link

Find a way to do the translations #62

Closed menor closed 7 years ago

menor commented 9 years ago

And decide if they are going to be based on browser language or in restaurant location

menor commented 7 years ago

What languages do we need there @mmarder ?

nsb commented 7 years ago

The widget is loaded with a URL that includes the language in the URL.

 static.resmio.com/de/widget.js

So my suggestion we would be to build a widget version per language. That should be doable with web pack. Then we could have a dir in the repo with a JSON representation of each language.

nsb commented 7 years ago

Ping me if you want to talk more about it.

nsb commented 7 years ago

We currently support these languages.

skaermbillede 2016-12-08 kl 12 45 31
mmarder commented 7 years ago

English German Spanish French Danish Dutch ... see list above :dancing_men:

menor commented 7 years ago

@nsb I want to avoid messing with webpack until there's no other option, that way this relies on create-react-app and we get updates and optimizations to the build system for free.

I was planning to include every language in the build since there is not much test, and then set the language in the initial config.

menor commented 7 years ago

Some options I'm considering in order of consideration:

menor commented 7 years ago

I'm trying to make Multilingual work and see how that goes

menor commented 7 years ago

Note to myself: stackoverflow.com/questions/33413880/react-redux-and-multilingual-internationalization-apps-architecture

menor commented 7 years ago

Ok got them working. They are stored in a store, so we serve the file with all the translations and can decide later if we want the language to be based on the facility, or OS.

Closing this for now

menor commented 7 years ago

@mmarder says that based on the OS

JannKleen commented 7 years ago

@nsb closing this then