Open wuzhuoquan opened 9 months ago
According to this closed PR: https://github.com/resmoio/kubernetes-event-exporter/pull/126#issuecomment-1779094127
This time I make the sentUpdateEvent
trigger to to each sink.
And also make the code gci-ed
with gci check.
Please check it.
This was a highly requested feature, so thanks, I'll review this soon. The only thing we need to be careful for on update events is setting IDs properly, so that underlying databases can update the item instead of growing it to eternity.
This was a highly requested feature, so thanks, I'll review this soon. The only thing we need to be careful for on update events is setting IDs properly, so that underlying databases can update the item instead of growing it to eternity.
hello? Do you have time to review and merge this pr?
Sorry for late response. However as I said we need to ensure all the sinks have proper IDs set in their responses in order to merge this to avoid ever growing data in the sinks such as Elasticsearch
if an event occur many times, It will only update the event fields like
count
andlastTimestamp
. By defaultkubernetes-event-exporter
will ignore the eventUpdate and will not sent to the recivers. If you Don't want to miss every event,you can use triggersentUpdateEvent
configurated in each sink to controll whether sent the event to the reciver.