search

resonai / ybt

Yet another Build Tool
Apache License 2.0
2 stars 2 forks source link

python test link in build #236

Closed dana-resonai closed 2 years ago

dana-resonai commented 2 years ago

move the linking of all the relevant files to the python test target directory to run on build and not on test.

The reason for this: First, it makes more sense that the build phase is in charge to pack all the dependencies in one place. Second, this allows us to run ybt build on the test target and then manually run the test command with the relevant docker & mappings (as we do in cpp test)

Please let me know if there is any good reason not to move it.

This will help both @shirl-resonai and @amirbennatan

dlehavi-resonai commented 2 years ago

@itamaro it was some travis and appveyor issues both of which I resolved in a separate PR: travis had a problem with egg_info in 3.7, and appveyor had some issue with the entire concept of 3.5; I have to say I agree with it: I have a problem with the entire concept of python.

itamaro commented 2 years ago

I have a problem with the entire concept of python

The story of my life

eyal-resonai commented 2 years ago

I think this is broken due to bad interaction with global cache - when we have a global cache for the python test (and no local one) we are not fetching all the needed files to allow the test to run.