search

resonatecoop / id-server-template

Resonate Coop ID Server
Mozilla Public License 2.0
3 stars 3 forks source link

Establish syntax rules and a linter for this repository #12

Closed angusmcleod closed 3 years ago

angusmcleod commented 3 years ago

Establish syntax rules and a linter for this repository, and perorm the first repo-wide syntax correction. The linter should be added to the CI, depending on whether #9 is complete or not.

tpltnt commented 3 years ago

Go has a syntax formatting rules which can be enforced with gofmt. Is that what you are looking for?

angusmcleod commented 3 years ago

Yup, that looks like what we need :+1:. Perhaps packaged as a pre-commit script: https://github.com/golang/go/blob/release-branch.go1.1/misc/git/pre-commit. Would you mind making a PR adding that as a pre-commit script if you agree that's the way to implement to ensure adherence by multiple contributors?

tpltnt commented 3 years ago

Making hooks part of a repo is considered bad practice, because it can result in pretty sneaky actions. I will open a separate PR addressing this after #15 is merged.