resonatecoop / id-server-template

Resonate Coop ID Server
Mozilla Public License 2.0
3 stars 3 forks source link

removed TestRecoveryMiddlewareHandlesPanic() #18

Closed tpltnt closed 3 years ago

tpltnt commented 3 years ago

Hi there,

I removed TestRecoveryMiddlewareHandlesPanic() because the very idea of a panic is to crash the process. A panic means an internal fatal error in which either it is unable to safely recover or continuing to run the system would have a higher risk of major data loss. If a program is able to detect such a condition it should stop work and present itself for debugging. Continue to run when it is known that the program is in an inconsistent state is adventurous at best. Crashes are ok. Crashes are good because we can learn from them and do not lie to the user about the internal consistency (and about the scenario for which the program was designed).

Cheers, tpltnt

tpltnt commented 3 years ago

ping