resonatecoop / mobile

A mobile app for playing music on Resonate, an open source music streaming co-op; built with TypeScript and React Native
GNU General Public License v3.0
15 stars 2 forks source link

Setup react navigation and theme context #35

Closed dominictwlee closed 2 years ago

dominictwlee commented 2 years ago

So a couple of things I figured would make our lives easier once we get going with the different navigation flows in the app, along with styling consistences.

I went ahead and hooked up react-navigation. It uses the same react-native-paper component but integrated with a more feature-rich navigation system.

I then integrated up all the relevant theme systems from react-native-paper and react-navigation, consolidated them, and made the light/dark theme sync up with system preferences. If in the future we want to also create some kind of internal user settings within the app, that can also be done.

This will make the subsequent screens easier to implement.

Also, it seems the Player UI has a pre-existing bugs that cuts off overflown text. I'll raise an issue for that at #36

image

image

dominictwlee commented 2 years ago

thanks for the quick review!