search

resonatecoop / mobile

A mobile app for playing music on Resonate, an open source music streaming co-op; built with TypeScript and React Native
GNU General Public License v3.0
15 stars 2 forks source link

fix: track duration text overflow in player #41

Closed peterklingelhofer closed 1 year ago

peterklingelhofer commented 1 year ago

This hopefully closes #36.

Need to test iOS still and to make sure it doesn't break other screen sizes though.

image

peterklingelhofer commented 1 year ago

Okay, my later commit using BOTTOM_NAVIGATION_HEIGHT seems to make both iOS and Android happy. BOTTOM_NAVIGATION_HEIGHT seems to be the move for keeping things consistent between mobile operating systems.

Simulator Screen Shot - iPhone 13 - 2022-10-31 at 06 52 13

peterklingelhofer commented 1 year ago

@dominictwlee, if you have the time feel free to check this out and confirm that this resolves the issue for your Android device as well. If so, we can merge!