resonatehq / resonate

a dead simple programming model for the cloud
https://www.resonatehq.io
Apache License 2.0
405 stars 32 forks source link

Remove required for timeout and ttl fields #437

Closed dfarr closed 1 month ago

dfarr commented 1 month ago

The struct tag binding "required" excludes setting 0, which is valid for both ttl and timeout.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.05%. Comparing base (e4c6977) to head (f2f3658). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/coroutines/schedulePromises.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #437 +/- ## ========================================== - Coverage 57.07% 57.05% -0.02% ========================================== Files 115 115 Lines 11557 11559 +2 ========================================== - Hits 6596 6595 -1 - Misses 4497 4500 +3 Partials 464 464 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.