resonite-modding-group / ResoniteModLoader

A mod loader for Resonite
https://discord.gg/ZMRyQ8bryN
GNU Lesser General Public License v3.0
82 stars 6 forks source link

Current ModLoader.Version doesn't follow semantic versioning #13

Closed Banane9 closed 3 months ago

Banane9 commented 3 months ago

With the current changes from tag 2.6.0, the enum member IncompatibleConfigurationHandlingOption.FORCE_LOAD was removed. This is technically breaking backwards compatibility and as such would warrant a version bump to 3.0.0.

https://github.com/resonite-modding-group/ResoniteModLoader/compare/2.6.0...main

XDelta commented 3 months ago

The changes you are referring to were committed after the Version string change. Additionally, I haven't found any mods using the older option and it has been marked as obsolete since October. Hasn't been a release made for these changes and still a small few pending commits. By itself, while it may break 'strict' semver, I'd consider that as only a minor version bump. Where as the larger changes with the 'type update' and functionality of how the modloader works, even if most mods would still be expected to work, would more warrant the version bump, nevermind that several other options are being removed as they are no longer needed.

Will likely be changing to a 3.0.0 anyway because of the typing changes.