Open GoogleCodeExporter opened 9 years ago
I tried "make check" on sparsehash on a Mac with the latest xcode. It didn't
work. The attached patch was able to fix 3 warnings and, more seriously, a type
incompatibility.
I'm not ready to commit the patch yet (though I suspect it would be fine), and
it may take me a week or two to get to it. But, the patch is here if you want
to try it.
Original comment by gp...@google.com
on 26 Mar 2014 at 12:17
Attachments:
I now see that the patch mentioned in issue 100 is pretty much the same thing.
Thanks Meno!
Original comment by gp...@google.com
on 26 Mar 2014 at 12:21
Issue 100 has been merged into this issue.
Original comment by gp...@google.com
on 26 Mar 2014 at 12:21
Is the fix going to be merged to master?
Original comment by ivan.ver...@gmail.com
on 16 Apr 2014 at 4:15
Correct me if I'm wrong, but I suspect the root cause was that
sparse_hashtable_iterator::st_iterator,
sparse_hashtable_const_iterator::st_iterator, and
sparse_hashtable_destructive_iterator::st_iterator were not typedef-ef
correctly. So I propose the following patch for the type incompatibility issue
instead.
Original comment by qiu...@gmail.com
on 19 Apr 2014 at 10:22
Attachments:
there are a number of warning in the unit tests after applying the patch, but
otherwise is excellent
Original comment by cristeab
on 17 May 2014 at 6:33
Original issue reported on code.google.com by
laurent....@gmail.com
on 24 Mar 2014 at 5:52Attachments: