search

resource-disaggregation / jiffy

Virtual Memory Abstraction for Serverless Architectures
Apache License 2.0
45 stars 13 forks source link

Fix Auto-scaling issue in queue python client #115

Closed charles-typ closed 4 years ago

charles-typ commented 4 years ago

What changes were proposed in this pull request?

Change dequeue to mutator operation and modify the way to check the number of blocks existing in the queue. The previous implementation is wrong because it is checking self.block_info.data_blocks which is not updated as the queue scales.

How was this patch tested?

Tested here: https://github.com/ucbrise/jiffy/blob/4ec82a117825f2764bb791732b13d53276b49d7e/pyjiffy/test/test_client.py#L441 .

anuragkh commented 4 years ago

Does this issue also exist in C++ client?

charles-typ commented 4 years ago

No, this is only for python client. In C++ client we directly check the number of partitions with blocks_.size().