Closed rburghol closed 2 months ago
@rburghol , if I were to accept this PR as is, what would be the effect of these failed tests? Maybe they should be left out of the PR until we get those details resolved?
@rburghol , also, maybe this PR would look simpler if it had been issued against the develop branch? It seems these changes to GENER.py and main.py for instance, are in our develop branch but not our master branch.
@PaulDudaRESPEC -- you are totally right, this was made against master
and it definitely should be against develop
! Closing this in favor of #148
I will address your question about the failing tests there.
Setting this to trigger tests when making a PR to
master
,develop
anddevelop-specact
@PaulDudaRESPEC - don't know which ones are the best, but that seemed like a reasonable place to start for now? Note on the 3 tests currently enabled:[dev]
setup in linux environment -- currently fails during install step as[dev]
reference appears incorrect