respec / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
43 stars 17 forks source link

Testx #146

Closed rburghol closed 2 months ago

rburghol commented 3 months ago

Setting this to trigger tests when making a PR to master, develop and develop-specact @PaulDudaRESPEC - don't know which ones are the best, but that seemed like a reasonable place to start for now? Note on the 3 tests currently enabled:

PaulDudaRESPEC commented 3 months ago

@rburghol , if I were to accept this PR as is, what would be the effect of these failed tests? Maybe they should be left out of the PR until we get those details resolved?

PaulDudaRESPEC commented 3 months ago

@rburghol , also, maybe this PR would look simpler if it had been issued against the develop branch? It seems these changes to GENER.py and main.py for instance, are in our develop branch but not our master branch.

rburghol commented 3 months ago

@PaulDudaRESPEC -- you are totally right, this was made against master and it definitely should be against develop! Closing this in favor of #148 I will address your question about the failing tests there.