respec / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
43 stars 17 forks source link

Develop specact depend #150

Closed rburghol closed 2 months ago

rburghol commented 2 months ago

@PaulDudaRESPEC This push has 12 file changes in here, which look a bit voluminous, but the reality is that 2 Are clean-up, removing "test" functions, and old debug print statement (.gitignore and SPECL.py).

The rest are as follows:

rburghol commented 2 months ago

Thanks for the review @PaulDudaRESPEC -- I'll make these uci changes asap. As for the @njit instead of @njit(cache=True), I made that change as a test, and should have communicated about it. My sense is that it was important to do during debugging, as the cache=True argument appeared to be requiring me to reload my environment occasionally. That may have been a misunderstanding on my part -- regardless, I did not intend to leave it in there, though it might be worth seeing if it actually does anything positive and/or if it indeed can cause unwanted caching (I can verify that it does not eliminate pre-compiled speed ups).

rburghol commented 2 months ago

Changes done. Thanks again!

rburghol commented 2 months ago

Ah - thanks @PaulDudaRESPEC -- in all the switching back and forth I missed that. Done!

PaulDudaRESPEC commented 2 months ago

Perfect, thank you!