Closed austinorr closed 1 month ago
@PaulDudaRESPEC please review. This PR brings test coverage for all code in the project up to 70%. The failing last cli test looks like an additional packaging detail regarding the data files, but tests pass!
@PaulDudaRESPEC also, as of this PR you have the option to adopt a policy of having all PRs be required to pass the test suite (which will grow and change) in order for you to approve and merge. Your review will have to include a check to ensure the PR didn’t somehow make the test easier, haha.
should you adopt such a policy, and I think you should, let’s begin with this PR and hold it until I fix the data package bug. I think I know the fix.
@PaulDudaRESPEC This PR completes the following:
df = df.apply(pd.to_numeric, errors='ignore')
'ignore' is deprecated. implementing fix to use 'raise' or 'coerce' may require some refactoring. I tested 'coerce' but it breaks things.
This PR adds
pytest
to the optional project dependencies, and should get automated tests passing in CI (partially, there's another PR coming that fixes the packaging/install so that the cli works again).