Closed austinorr closed 2 months ago
I wanted to add some context to these changes, and first off, thanks @austinorr for spying that 6 hour runtime! That would kill our free tier of testing in a jiffy. Rather than deleting these tests, @PaulDudaRESPEC, I would nominate that we disable them rather than delete (see "Disabling a Test" in our main testing issue: #135) unless they are superfluous:
conda
route:
@rburghol tests and actions have been revised and improved in #156.
the conda test you mentioned above (1) tests ‘if things also run in an active conda environment’ — that test probably already covered in the conda project.
if we do our job, then our code will run fine in any environment manager that is also doing its job.
for the second item, tests written into gh actions for our master branch will run when someone opens a PR against master, and similarly for our develop branch code. Actions are committed into the git repo (not configured as part of the overall website) and so, if I understand your concerns correctly, they will already do the thing you describe by default and we don’t need a second dev action.
Hey @austinorr thanks for the responses:
yml
files to install variants, 1 which was limited to the 3.9.* python version, and the 2nd which was exploring some later versions (due to problems with numba
IIRC). So, the 2nd files was not for a separate branch, but rather, for a separate underlying system of requirements and python versions.numba
version snafu is no longer, it is probably not a bad idea to always have a forward looking install test which looks at cutting edge versions of python to see if any new problems are on the horizon.
Yeah, since these are causing trouble let's take them out for now, with the intent of restoring them when ready.