respec / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
43 stars 17 forks source link

UCI import with 15min timestep #22

Closed trees4me closed 3 years ago

trees4me commented 5 years ago

Hi, I have a UCI file that runs at 15min timestep. A couple issues have come up running the import checks, but I'm still unable to reproduce HSPF results.

Issues: 1) external sources evap record is 15-min with a 0.75 multiplier in HSPF. The MFACTOR comes into HSP2 ok, but needs to be divided by 96 (=4*24). After revising this MFACTOR the IMPLND and portions of the PERLND are ok.

2) The PERLND in HSP2 are not reproducing HSPF results. I've traced the source to the groundwater storage bin (AGWS/AGWO). Everything above that is nearly identical. The AGWI is nearly identical for HSP2 vs HSPF. perlnd_p211_pwater_agwi

However, the AGWO, AGWS, and GWVS all vary between HSP2 and HSPF. I checked all the PERLND parameters and states and they are the same. Evap is off on the groundwater bin (AGWET=BASET=0).

perlnd_p211_pwater_agwo perlnd_p211_pwater_agws

Trying to figure out what to try next. KGW appears to be 0 (AGWRC=0.997, DELT60=0.25 for 15min), and perhaps HSP2 is treating this case differently than HSPF? Is something else different about the groundwater routine? Perhaps the 15-min time step may be an issue here as it was with item 1. Any ideas are appreciated. Thanks.

JasonLoveRespec commented 5 years ago

Thanks for the detailed explanation of the issue. We will look into and get back to you with any information.

JASON LOVE, P.E. Senior Vice President

605.394.6512 office // 605.484.2380 cell


From: trees4me notifications@github.com Sent: Tuesday, January 29, 2019 3:06 AM To: respec/HSPsquared Cc: Subscribed Subject: [respec/HSPsquared] UCI import with 15min timestep (#22)

Hi, I have a UCI file that runs at 15min timestep. A couple issues have come up running the import checks, but I'm still unable to reproduce HSPF results.

Issues:

  1. external sources evap record is 15-min with a 0.75 multiplier in HSPF. The MFACTOR comes into HSP2 ok, but needs to be divided by 96 (=4*24). After revising this MFACTOR the IMPLND and portions of the PERLND are ok.

  2. The PERLND in HSP2 are not reproducing HSPF results. I've traced the source to the groundwater storage bin (AGWS/AGWO). Everything above that is nearly identical. The AGWI is nearly identical for HSP2 vs HSPF. [perlnd_p211_pwater_agwi]https://user-images.githubusercontent.com/35086910/51899915-df36eb00-2368-11e9-96d7-8dbe15fb0fd0.png

However, the AGWO, AGWS, and GWVS all vary between HSP2 and HSPF. I checked all the PERLND parameters and states and they are the same. Evap is off on the groundwater bin (AGWET=BASET=0).

[perlnd_p211_pwater_agwo]https://user-images.githubusercontent.com/35086910/51900254-b4996200-2369-11e9-8348-5c454e6ec547.png [perlnd_p211_pwater_agws]https://user-images.githubusercontent.com/35086910/51900255-b4996200-2369-11e9-8457-83adb44484c1.png

Trying to figure out what to try next. KGW appears to be 0 (AGWRC=0.997, DELT60=0.25 for 15min), and perhaps HSP2 is treating this case differently than HSPF? Is something else different about the groundwater routine? Perhaps the 15-min time step may be an issue here as it was with item 1. Any ideas are appreciated. Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/respec/HSPsquared/issues/22, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcYK3oh45LvmSJamLPLAMk3yYcWxzjU9ks5vIB03gaJpZM4aXs2E.

Confidentiality Notice: This E-mail and any attachments is covered by the Electronic Communications Privacy Act, 18 U.S.C. & 2510-2524, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, and permanently delete the original and destroy any copy, including printed copies of this email and any attachments thereto.

trees4me commented 5 years ago

I did a quick test with DELT=60min and the perlnds/implnds are ok. It's appears to be an issue related to the 15min time step, where KGW trends to 0. At 60min DELT the KGW value is non-0.

Thanks -Pat

perlnd comparison table HSP2 (60min) vs HSPF (15min), reasonable monthly results.

Max Diff Sum of HSPF Sum of HSP2 %diff of Sum abs(%diff of Sum)
274 1.36 547.93 548.01 -0.01 0.01
241 1.45 534.70 534.28 0.08 0.08
242 1.45 533.44 533.02 0.08 0.08
243 1.45 532.21 531.77 0.08 0.08
244 1.45 530.87 530.42 0.08 0.08
273 1.30 514.84 514.28 0.11 0.11
231 1.43 505.02 504.26 0.15 0.15
233 1.40 500.49 499.73 0.15 0.15
234 1.41 499.73 498.96 0.15 0.15
232 1.43 504.22 503.44 0.15 0.15
284 1.36 435.23 434.46 0.18 0.18
211 1.03 401.23 400.39 0.21 0.21
272 1.23 460.03 458.95 0.23 0.23
221 1.33 452.18 451.07 0.24 0.24
212 1.12 417.38 416.35 0.25 0.25
222 1.36 462.33 461.17 0.25 0.25
223 1.32 454.83 453.68 0.25 0.25
224 1.33 454.92 453.76 0.25 0.25
271 1.12 415.12 414.07 0.25 0.25
213 1.28 441.69 440.51 0.27 0.27
214 1.36 464.83 463.58 0.27 0.27
283 1.24 401.24 400.12 0.28 0.28
282 1.10 382.03 380.94 0.29 0.29
285 1.10 382.03 380.94 0.29 0.29
281 1.13 384.55 383.40 0.30 0.30
aufdenkampe commented 3 years ago

@trees4me, although you posted this issue 2 years ago, it might be of interest that there's been renewed work on this in the last 6-9 months, as tracked with:

If you are still using this, or interested in helping us test, some of the more recent updates discussed there are still on the develop branch.

aufdenkampe commented 3 years ago

Closing this issue as it's now been implemented with closing of #40.