respec / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
43 stars 17 forks source link

Merge LimnoTech readWDM & other updates to RESPEC develop #52

Closed aufdenkampe closed 3 years ago

aufdenkampe commented 3 years ago

This Pull Request brings an important set of enhancements to the readWDM.py functions, as described in LimnoTech's internal Merge develop_readWDM into develop to read time series by block & group #37. Please read the description of that PR for a full description of changes, testing and Unaddressed Issues.

Note that @ptomasula paid careful attention to resolving conflicts with @TongZhai's new get_wdm_data_set() function in readWDM.py to support the new automated regression testing capabilities. Tong's get_wdm_data_set() uses now deprecated routines (i.e. getfloats() and others). Although get_wdm_data_set() will work with these older routines, we will eventually want to rewrite get_wdm_data_set() to use the new _process_groups(), which is both faster and more accurate. @ptomasula added deprication warnings to all the old functions that we want to stop using.

Other improvements include updates to recommended Conda environments and the inclusion of reference documentation.

cc: @PaulDudaRESPEC, @TongZhai, @ptomasula