respec / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
43 stars 17 forks source link

Small differences in numeric precision lead to test run showing benthic algae differences #63

Open PaulDudaRESPEC opened 2 years ago

PaulDudaRESPEC commented 2 years ago

For a particular test case, in the benthic algae component of PLANK, the computed benthic algae density increases with each time step until it crosses the threshold set by input parameter MBAL in table BENAL-PARM, as expected. Crossing this threshold occurs one time step later in HSP2 than it did in HSPF. After closer examination, it is apparent the differences in benthic algae density are within the expected numeric precision, but the small difference is enough to affect the occurrence of overcrowding by one time step.

This issue focuses a possible shortcoming of the testing code, where comparing each value at each time step can provide misleading indications of non-matching results.