search

respec / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
43 stars 17 forks source link

Merge Develop into Master for release v0.10.1 #88

Closed aufdenkampe closed 2 years ago

aufdenkampe commented 2 years ago

This PR would complete the issues Milestone v0.10.1: Additional Documentation & Fixes, which includes:

We would like to complete the following issues before the release, in order of priority:

I'll work on completing #83 today so that we can issue the release v0.10.1 early next week to resolve this recent issue:

Any progress that I'm able to make on #71 by Monday will be a bonus, but whatever I don't get done we can postpone that to the next round of work.

@PaulDudaRESPEC, I'll let you know when I'm done with #83 and at a reasonable stopping point with #71.

aufdenkampe commented 2 years ago

@PaulDudaRESPEC, I finally got around to updating the notebooks to document and demo the bug fixes that you and @ptomasula made back in the winter!

Let's move forward with release v0.10.1!

ptomasula commented 2 years ago

Not to delay a release any longer, but @bcous found another potential bug this morning (#93), which I'm looking into. It might be worth holding off for a day so that any potential fixes related to this bug could also be incorporated into the release.

Though I'm also ok with going forward if there is a real need and we can always release a v0.10.2 with a fix to that issue.

aufdenkampe commented 2 years ago

@ptomasula, if you think you can fix that bug in the next week or so, let's wait until you are done with:

ptomasula commented 2 years ago

@PaulDudaRESPEC @aufdenkampe I closed out issue #93. I think it is fine to move forward with the release. The issue did uncover some potential needs to make the logic for controlling save parameters more robust, but I think that will be more involved and probably its own PR.

aufdenkampe commented 2 years ago

@ptomasula, that's great news! Thanks for investigating that.

@PaulDudaRESPEC, let's move forward with merging this PR and issuing the release. I'm happy to draft up some release notes if you like.