search

respec / solar-suitability-app

Solar Suitability Application
4 stars 3 forks source link

created maxExtent, return to original extent if outside #39

Closed cmartin616 closed 8 years ago

andywalz commented 8 years ago

need to suppress alert and fix solar layer disappearing image

cmartin616 commented 8 years ago

I added extent error checking to geolocator and navbar 'find me'. It alerts, waits 3 seconds and re-centers on the original extent. Do we want the user to close out this alert or kill it programatically after the map move??

I also think the solar layer not displaying was a server issue as I can't replicate. Did you check the console to see if there was an error?

andywalz commented 8 years ago

limitExtent is now presenting with some strange projections issue (only on initial load...panning/zooming fixes it): capture 20

cmartin616 commented 8 years ago

I'm working on this. For some reason, the map loading fires on('change-extent') and causes the skewing. Removing the map.setExtent fixes it but then it defeats the purpose. I'm researching it with Esri internally.

andywalz commented 8 years ago

Are you using the alert function I added? I think ok for it to timeout but I had the timeout commented out for testing in some branches.

On Oct 23, 2015, at 1:58 PM, Chris Martin notifications@github.com wrote:

I added extent error checking to geolocator and navbar 'find me'. It alerts, waits 3 seconds and re-centers on the original extent. Do we want the user to close out this alert or kill it programatically after the map move??

— Reply to this email directly or view it on GitHub https://github.com/flatrockgeo/solar-suitability-app/pull/39#issuecomment-150663481.

cmartin616 commented 8 years ago

Current method for geolocate and find me is to go to the location (can't really prevent the functionality or people will be confused why), it displays an alert (using your function), waits 3 seconds (so the user isn't confused) and re-centers on the original location.

The alert persists at this point, as I feel it should. I'm curious if you think it should disappear after X seconds once re-centered or force the user to click the X to dismiss?

andywalz commented 8 years ago

I like disappear after 3.5 seconds but Paul says just let it persist and force click. There is no voice of the people!

On Oct 28, 2015, at 9:52 PM, Chris Martin notifications@github.com wrote:

Current method for geolocate and find me is to go to the location (can't really prevent the functionality or people will be confused why), it displays an alert (using your function), waits 3 seconds (so the user isn't confused) and re-centers on the original location.

The alert persists at this point, as I feel it should. I'm curious if you think it should disappear after X seconds once re-centered or force the user to click the X to dismiss?

— Reply to this email directly or view it on GitHub https://github.com/flatrockgeo/solar-suitability-app/pull/39#issuecomment-152057037.

cmartin616 commented 8 years ago

This appears to now be working on my machine. Can you check it? The xmax was set too low so the extent change and move was firing on load. We may need to buffer xmin, ymin and ymax as well but I haven't seen it cause issues yet.

andywalz commented 8 years ago

Still having alignment issues and now can't zoom at all.

cmartin616 commented 8 years ago

I'm discontinuing this.