search

respond-framework / rudy

Rudy Router - MVC style route async controller for react-redux applications.
MIT License
80 stars 8 forks source link

Clicking on the same route does not re-apply the internal state #1

Open ScriptedAlchemy opened 6 years ago

ScriptedAlchemy commented 6 years ago

Run the demo, click on home, then react, then redux, then react again. The content does not change.

looks related to the on_complete middleware not being called when the user clicks on a previous like (going back in history according to deloris)

After Further investigation, its caused by call('thunk', { cache: true }),

When the thunk is not cached, it works as expected.

Need to look at either caching state, or ensuring that the thunks result is properly restored to the store

hedgepigdaniel commented 5 years ago

I think its because the packages reducer only responds to LIST_COMPLETE (not LIST), and when the thunk is cached only LIST is dispatched.

I feel like the best solution here is to change the reducer in the boilerplate app to respond to the routing action (LIST). If we want to make sure the data is available before the page is rendered, then we can use beforeChange (or any other middleware that is before enter)