search

respondcreate / django-versatileimagefield

A drop-in replacement for django's ImageField that provides a flexible, intuitive and easily-extensible interface for quickly creating new images from the one assigned to the field.
http://django-versatileimagefield.readthedocs.io/
MIT License
531 stars 88 forks source link

Still show the widget even if thumbnailing fails/crashes #104

Closed matthiask closed 7 years ago

matthiask commented 7 years ago

When an image is not uploaded completely the sizers crash. This has been discussed several times before (resp. crashes when the image file does not exist etc.), and fixes have been rejected. (I do not fully agree with the resolution, but that's not the point of this pull request.)

However, it should still be possible to remove or replace these files again. The current implementation which calls .thumbnail['300x300'] prevents this by causing the whole fieldset containing the versatile image field admin widget to disappear.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.783% when pulling 79f15dfb59cebdfd38ff9ca23225777349279bd3 on matthiask:master into 1fc59b8f850a30c42a668ad21572331699801a3a on respondcreate:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.783% when pulling 79f15dfb59cebdfd38ff9ca23225777349279bd3 on matthiask:master into 1fc59b8f850a30c42a668ad21572331699801a3a on respondcreate:master.

matthiask commented 7 years ago

So this problem just hit us again. @respondcreate anything I can do to help, to get things moving again?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6fc9bc60e690eb6fa72da1bd0f90d2ffa7273be8 on matthiask:master into 1fc59b8f850a30c42a668ad21572331699801a3a on respondcreate:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6fc9bc60e690eb6fa72da1bd0f90d2ffa7273be8 on matthiask:master into 1fc59b8f850a30c42a668ad21572331699801a3a on respondcreate:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1d7359d7855f5b857a9c6bb283cc3eaac95ab2b7 on matthiask:master into 1fc59b8f850a30c42a668ad21572331699801a3a on respondcreate:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7ddc0c9ad888a5dc32b957a271919d801117fc54 on matthiask:master into 1fc59b8f850a30c42a668ad21572331699801a3a on respondcreate:master.

respondcreate commented 7 years ago

Hey @matthiask !

Just saw that the tests are now passing on this PR, thanks so much! Unfortunately I'm in the middle of a move at the moment so I won't be able to review, merge and release to PyPI until next week. If I haven't responded in this thread by Tuesday, October 2nd, would you mind pinging me again in this thread so I don't forget?

My apologies for the delay!

matthiask commented 7 years ago

Hey @respondcreate, I hope the move went well! Pinging you as requested :-) I'd appreciate a short feedback on #105 as well, it is related to this pull request. Thanks in advance.

matthiask commented 7 years ago

Pinging you again @respondcreate Thanks for your attention in advance.

respondcreate commented 7 years ago

Hey @matthiask!

This PR has been merged and is available in the just-minted 1.8 release. Here's how you can get it:

$ pip install django-versatileimagefield

Thanks so much for your contribution to this project (and my apologies for the wait on getting this merged)!