search

responsiv / pay-plugin

Payment system for October
Other
52 stars 45 forks source link

Installation #46

Closed jestherthejoker closed 3 years ago

jestherthejoker commented 6 years ago

Installation on October CMS won't work using the plugin manager doesn't work for me.

Does the ff is required to install the pay-plugin:

acasar commented 6 years ago

@daftspunk @LukeTowers Seems like something broke in the dependency chain:

    - omnipay/common v3.0.2 requires php-http/client-implementation ^1 -> no matching package found.
    - omnipay/common v3.0.1 requires php-http/client-implementation ^1 -> no matching package found.
    - omnipay/common v3.0.0 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.3 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.1 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.4 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.3 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.1 requires php-http/client-implementation ^1 -> no matching package found.
    - omnipay/common v3.0-RC2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-RC1 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common 3.0.x-dev requires php-http/client-implementation ^1 -> no matching package found.
    - remove omnipay/braintree 2.0.x-dev|keep omnipay/braintree dev-master

I also opened an issue here: https://github.com/thephpleague/omnipay-common/issues/189 but got redirected back

LukeTowers commented 6 years ago

@acasar why is it trying to load omnipay/common 3.0?

acasar commented 6 years ago

@LukeTowers I'd say omnipay/braintree is the one requiring it: https://github.com/thephpleague/omnipay-braintree

We are requiring "omnipay/braintree": "~2.0" which by the looks of it doesn't even exist: https://github.com/thephpleague/omnipay-braintree/releases

LukeTowers commented 6 years ago

@acasar are there any problems with upgrading the dependencies?

acasar commented 6 years ago

@LukeTowers We should update composer.json to fix this issue. Yesterday I started using my fork, where I made this change: https://github.com/acasar/pay-plugin/commit/01348756aea3b1897f08622131274cdcfb66909d

The issue is that with this commit 13 days ago https://github.com/thephpleague/omnipay-braintree/commit/74a8ed2773c6185226b4d845a11e18e29c15b42b omnipay/braintree upgraded to omnipay/common 3.0. But it's not tagged yet, so it normally shouldn't cause any issues.

But since we're requiring version 2.0 of omnipay/braintree (which doesn't even exist), we are always getting dev-master with all latest commits. So 13 days ago, when this change was made, responsiv/pay could not be installed using composer any more. And I guess installing through October's package manager will soon have problems too.

LukeTowers commented 6 years ago

@acasar installing through the marketplace won't be an issue, it precomiles the builds which includes the libraries in the plugin /vendor folder at compile time so no worries there. Feel free to make a PR here with the required changes.

What's the compatibility of just using 3.0 vs 1.0?

acasar commented 6 years ago

@LukeTowers Created a PR here: https://github.com/responsiv/pay-plugin/pull/48

installing through the marketplace won't be an issue, it precomiles the builds which includes the libraries in the plugin /vendor folder at compile time so no worries there.

Still, it will probably fail on the next recompile, since it would be unable to install composer dependencies.

What's the compatibility of just using 3.0 vs 1.0?

You mean omnipay/common 3.0 vs 2.0, that we are using now? It has a few breaking changes so some other changes would be needed as well.

LukeTowers commented 6 years ago

@acasar would you be willing to make the changes required to upgrade to 3.0?

acasar commented 6 years ago

@LukeTowers When I have a bit more time I can try and tackle this. For now, fixing braintree dependency seems to have solved the issue. Thanks!

daftspunk commented 3 years ago

Moved to #66