responsively-org / responsively-app

A modified web browser that helps in responsive web development. A web developer's must have dev-tool.

https://responsively.app

GNU Affero General Public License v3.0

22.8k stars 1.2k forks source link

Feature/767 accept language #1334

Closed happymvp closed 3 weeks ago

happymvp commented 4 weeks ago

✨ Pull Request

📓 Referenced Issue

Resolves: #767

ℹ️ About the PR

Added new setting section with Request Headers parameter.

Potentially interesting topic to discuss: Adding default values resolution as described in https://github.com/sindresorhus/electron-store/issues/92.

For me this is valid issue and default value of electron store never showed up.

🖼️ Testing Scenarios / Screenshots

CLAassistant commented 4 weeks ago

All committers have signed the CLA.

happymvp commented 4 weeks ago

Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.

Doesn't seem like error I should deal with as part of this PR

violetadev commented 3 weeks ago

Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.

Doesn't seem like error I should deal with as part of this PR

I am not able to merge this pr until this has been resolved, it simply doesn't let me merge with pipeline errors, and it seems that this has been raised from your changes as we merged other prs just fine before this one. Could you take a look? Thanks

happymvp commented 3 weeks ago

Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'. Doesn't seem like error I should deal with as part of this PR

I am not able to merge this pr until this has been resolved, it simply doesn't let me merge with pipeline errors, and it seems that this has been raised from your changes as we merged other prs just fine before this one. Could you take a look? Thanks

Now everything is correct

violetadev commented 3 weeks ago

thank you for your contributions!

@all-contributors Please add @happymvp for code

allcontributors[bot] commented 3 weeks ago

@violetadev

I've put up a pull request to add @happymvp! :tada:

violetadev commented 3 weeks ago

@all-contributors Please add @happymvp for test

allcontributors[bot] commented 3 weeks ago

@violetadev

I've updated the pull request to add @happymvp! :tada: