search

responsively-org / website

Source code that is powering Responsively website, made using Next.js and Tailwind.
https://responsively.app
MIT License
21 stars 39 forks source link

fix: compress videos to reduce file size #28

Closed lsprr closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
responsively-app-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 8:09pm
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

manojVivek commented 1 year ago

Hi @lsprr, can you please share some details on the technique used for compressing the videos?

We just wanted to make sure the quality of the videos was not compromised.

lsprr commented 1 year ago

Hi @manojVivek,

Sure, I'd be happy to share the details.

For the video compression, I've used Handbrake (https://handbrake.fr/downloads.php), a tool that's popular for its effectiveness in video compression without significant loss of quality. Handbrake allows for fine-tuning of various parameters to achieve a good balance between video size and quality.

In the process of compressing the videos, I paid close attention to ensuring the quality was not compromised. I reviewed each video thoroughly post-compression to confirm that the visual quality still meets our standards. If you'd like, I'd encourage you to also review the compressed videos and share your feedback.

On another note, I'm currently working on a new pull request targeted at improving accessibility. I hope to have that ready soon and will notify you once it's ready for review.

Please let me know if this approach works for you or if there are any other aspects you'd like me to focus on.

Best, Luis

manojVivek commented 1 year ago

@lsprr Thanks for the detailed explanation! That makes perfect sense, thanks for this improvement! 🚀

Looking forward to the accessibility improvement too!