search

resque / resque-scheduler

A light-weight job scheduling system built on top of Resque
MIT License
1.74k stars 481 forks source link

Separate Rubocop and specs into two GH Action workflows #722

Closed sharang-d closed 3 years ago

sharang-d commented 3 years ago

What?

Fix CI! As requested in https://github.com/resque/resque-scheduler/issues/712#issuecomment-925380319 :)

How?

Separate Rubocop and Ruby specs into two different GitHub Action workflows.

Why?

Some builds were failing because Rubocop was failing on some Rubies. We don't need to run Rubocop against all Rubies so we now run Rubocop with only one ruby implementation.

I referred to https://github.com/rails/webpacker/tree/d7adcd20ddb77097a99a27f94491e78884c6ec59/.github/workflows for inspiration.

sharang-d commented 3 years ago

@iloveitaly I think you (/someone else with access) needs to turn off the TravisCI required check.

sharang-d commented 3 years ago

Do we still need AppVeyor? I don't think so. I will remove it after you confirm it's safe to go.

iloveitaly commented 3 years ago

This looks great, thank you!