resque / resque-scheduler

A light-weight job scheduling system built on top of Resque
MIT License
1.74k stars 481 forks source link

Use `Resque::DataStore#reconnect` for redis-rb v5.0 #756

Closed mishina2228 closed 2 years ago

mishina2228 commented 2 years ago

This PR will fix a part of #750.

Redis::Client#reconnect has been removed from redis-rb v5.0.0. This PR replaces it with Resque::DataStore#reconnect. It is available since Resque v1.27.0, so it is backward compatible.

mishina2228 commented 2 years ago

Test failure is not directly related to this PR. I created #757 for it.

mishina2228 commented 2 years ago

@PatrickTulskie @iloveitaly If you have a chance, would you mind review this PR? Thanks!

PatrickTulskie commented 2 years ago

Actually going to close this since it looks like these changes are in #757 and that is passing CI... also it would have a merge conflict if I did this one first. Thanks!

mishina2228 commented 2 years ago

Thank you! and sorry for inconvenience caused by the conflict. 🙇 I didn't include the README change in #757, so I will submit another PR.

mishina2228 commented 2 years ago

I've just submitted #760.

PatrickTulskie commented 2 years ago

Gotcha. 4.7.0 has been released with this and the readme update. Thanks for helping out!