search

resque / resque-web

a Rails-based web interface to Resque
235 stars 166 forks source link

Add job ID to Queue show and Job Failure page #120

Closed omarqureshi closed 7 years ago

kiyanwang commented 8 years ago

What happens if the id is not set? i think we saw yesterday that payload['id'] is set by the php-resque framework but not by ruby / node ... does this take that into account?

omarqureshi commented 8 years ago

Nil.to string is the empty string. So should be ok

On 23 Sep 2016 7:10 a.m., "Nadeem Shabir" notifications@github.com wrote:

What happens if the id is not set? i think we saw yesterday that payload['id'] is set by the php-resque framework but not by ruby / node ... does this take that into account?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/resque/resque-web/pull/120#issuecomment-249110929, or mute the thread https://github.com/notifications/unsubscribe-auth/AACJnTBChaGCZb_ELXbUnkANmwn7Zdbtks5qs21HgaJpZM4KD_Dg .

kiyanwang commented 8 years ago

Nil.to string is the empty string. So should be ok

awesome

👍

kirillplatonov commented 7 years ago

@omarqureshi thanks for your PR. Nice job! It's merged in master now and I will release it with new version soon.