Retry failed job, chooses incorrect job

[mintotsai]

I have a situation where I'm retrying a failed job and it retries an incorrect job instead of the one I chose. Maybe that I have 986 pages of failed jobs (see image below), and resque can't handle the large amount.

To reproduce:

1. Go to Failed tab
2. Scroll to bottom where it shows numbering for multiple pages of failed jobs
3. Click on the highest number for latest page of failed job
4. Go to a failed job
5. Click retry

[mlh758]

I think the issue here is that the id used in the parameter appears to actually be the index into the failed queue. If the failure list is changing while this happens, that index could end up being incorrect.

Controller method Redis datastore for failure

[glensc]

@mlh758

🚧 Never link to branches, share a permalink 🚧

• see https://news.ycombinator.com/item?id=8046710 and https://help.github.com/articles/getting-permanent-links-to-files/ and https://docs.gitlab.com/ee/user/shortcuts.html#project-files
• hit y
• and perhaps for https://github.com/josephfrazier/octopermalinker (GitHub)

---

corrected links:

• https://github.com/resque/resque-web/blob/master@%7B2019-09-16T15:57:26Z%7D/app/controllers/resque_web/failures_controller.rb#L48
• https://github.com/resque/resque/blob/master@%7B2019-09-16T15:57:26Z%7D/lib/resque/failure/redis.rb#L80