search

resque / resque-web

a Rails-based web interface to Resque
235 stars 166 forks source link

Gems updated #93

Closed mattgibson closed 9 years ago

mattgibson commented 9 years ago

I think this failure is the one that prompted me to add the .dotenv thing in the other PR. I'm assuming it's a change in the way something works and will add it in again here.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.78%) to 84.15% when pulling 311c52b00b15af7f6f7b29e9d4e5be2d6eec20a7 on mattgibson:gem-update into 10f2d2e328843487c5dd251a010dffd6a3b10f8e on resque:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.96%) to 84.32% when pulling 4e00d8e2084a8d2fd80498ebd6ee760d16603c3e on mattgibson:gem-update into 10f2d2e328843487c5dd251a010dffd6a3b10f8e on resque:master.

mcfiredrill commented 9 years ago

So I'm guessing its the basic auth username/password that need to be loaded by dotenv for some reason? It might be better to load that explicitly in the test instead, I'm not sure.

Thanks for this though, I will merge it.

mattgibson commented 9 years ago

Yeah, that was the test that was failing. I'm not sure of the best approach either. The previous behaviour was that it was implicitly required, so this is the closest to how it was.