Update attachRetryStrategy

[mbourqui]

Either this line is not supposed to be there, or the above if-loop is pointless.

[PhilETaylor]

As https://github.com/resquebundle/resque/blob/master/README.markdown states right near the end, the retry strategy should be an array, even if the array is a blank array (which should overrule the global retry strategy)

Therefore I think the count() lines should be there, and the other line should be removed as proposed.

[mbourqui]

But then precisely, shouldn't the test just be is_array? Otherwise, if it is an empty array, the count() will return 0 which is evaluated as false, and the global config will be set.

[PhilETaylor]

im looking into this today

[mbourqui]

Well, after looking more closely at it, it works as explained in the docs. The only difference is that if the array is empty, the $job->args['resque.retry_strategy'] will not be set. I do not know though if this is mandatory.

[PhilETaylor]

sorry was just typing that out :) too... thats the bit im testing now, I dont think its needed.

[PhilETaylor]

its used here https://github.com/resquebundle/resque/blob/762727ad1a2e06465e73ef8af282514f794795f3/bin/resque#L108

and a quick test proves no error/warning will be generated if not set

<?php
$args = [];
var_dump(empty($args['resque.retry_strategy']));

[mbourqui]

Great, seems we're all good then!

[mbourqui]

Thanks for double-checking and sorry for the doubt.