Fix ADVERTISE_IP to work with structured ingress paths

[UnstoppableMango]

Moves ADVERTISE_IP logic to a helper function Fixes the regression from #52

I believe this should have roughly equivalent output to the original.

Here are a few of the commands I tested with helm template . --set 'ingress.enabled=true' --set 'ingress.hosts[0]=test.example.com' --set 'ingress.hosts[1]=test2.example.com' helm template . --set 'ingress.enabled=true' --set 'ingress.hosts[0].host=test.example.com' --set 'ingress.hosts[1].host=test2.example.com'

I noticed that on main the first url doesn't seem to get a :443 variant and is duplicated instead. Was this intentional?

Main renders:

- name: ADVERTISE_IP
  value: |
    https://test.example.com,https://test2.example.com
    ,https://test.example.com,https://test2.example.com:443

This branch renders (whitespace added for readability):

- name: ADVERTISE_IP
  value: |
    https://test.example.com,https://test.example.com:443
    ,https://test2.example.com,https://test2.example.com:443

[ressu]

I did a bit of a rework of all of the advertiseIp handling. Does it still work as intended for you? I tried to break it in all the ways I could think of and always ended up getting reasonable results.

[UnstoppableMango]

LGTM! @heliochronix is this good for you as well?

Sorry again for breaking it!

[ressu]

Heh, don't worry about breaking things. That's just part of the normal process.

[heliochronix]

From what I see, looks good. I'm no expert in helm templates though haha.