Support for HTTP Digest Authentication

rest-client / rest-client

Simple HTTP and REST client for Ruby, inspired by microframework syntax for specifying actions.

https://rubydoc.info/github/rest-client/rest-client/master

MIT License

5.24k stars 931 forks source link

Support for HTTP Digest Authentication #102

Open adelevie opened 12 years ago

adelevie commented 12 years ago

This is a great library, but I need HTTP Digest Authentication. I'm thinking of writing a patch to support it. Any thoughts?

L2G commented 11 years ago

I saw that @jbro closed #121 today, but #122 purports to be an improved version of his patch. Have either of you looked at it yet?

Sorry this has been so long overdue.

jbro commented 11 years ago

I was just doing some spring cleaning on my pull request, and @petur03's patch is better.

mmmries commented 11 years ago

this issue and #122 should be closed since the #122 pull request already merged and released. These issues should be closed to clean up the log.

L2G commented 11 years ago

Where was this merged and released?

vhochstein commented 11 years ago

Would love to see digest support integrated. However, I have to agree with L2G, I have nt seen that a pull request for digest authentication was merged.

mmmries commented 11 years ago

Oh, I see that this has not actually been merged. It looks like #122 is actually pending a merge and is set for milestone 1.7.0. I thought it had been merged because I am actually using this to talk to a digest auth server at work right now. But it turns out someone on the team actually built a copy of the gem with these changes merged in and pushed it to our internal gem server.

Sorry for the confusion, but +1 on this pull request since it is working for me in production right now.

RestClient::Resource.new "http://#{config['host']}/#{basepath}", config['username'], config['password']

L2G commented 11 years ago

Good to know!

vhochstein commented 11 years ago

I ve created my own fork and tried out pull request 122. Unfortuently, I ran into three issues using ruby 1.8.7:

ssl_version undefined method
@method.upcase not defined for symbol
unknown algorithm ""MD5"" (Net::HTTP::DigestAuth::Error)

I ve fixed all of these errors my fork.

vhochstein commented 11 years ago

I ve fixed one additional issue in my fork concerning digest auth. rest-client resource class did not reuse digest auth credentials for following requests.

akostadinov commented 9 years ago

@vhochstein , would you then file a PR with your fixes so #122 can be closed and this change finally merged. It appears to me original author of #122 is no longer interested.

andrepintorj commented 9 years ago

@vhochstein I'm also using your fork with no problems at all.