rest-for-physics / framework

The main project containing the core C++ classes defining framework behaviour and primordial analysis and helper tools. It centralises all other rest-for-physics repositories through submodules.
GNU General Public License v3.0
19 stars 11 forks source link

TRestDataSetPlot improvements #520

Closed AlvaroEzq closed 4 months ago

AlvaroEzq commented 4 months ago

AlvaroEzq Medium: 159 Powered by Pull Request Badge

AlvaroEzq commented 4 months ago

Getting rid of the keys variable, metadata and observable would simplify a lot the code as it would get rid of the following duplicated code lines: https://github.com/rest-for-physics/framework/blob/d31c89d501817ec6e93663fd1c6f24e62a7fc9ab/source/framework/core/src/TRestDataSetPlot.cxx#L353-L391 https://github.com/rest-for-physics/framework/blob/d31c89d501817ec6e93663fd1c6f24e62a7fc9ab/source/framework/core/src/TRestDataSetPlot.cxx#L589-L634

But they are needed in TRestDataSetPlot::GenerateDataSetFromFilePattern(). A possible workaround could be to use the double [[]] encapsualting variable keywords ( e.g. [[entries]] ), the single [] encapsulating metadata (e.g. [TRestDetector::fPressure]) and naked observable names (e.g. rawAna_ThresholdIntegral) to identify them inside that method.