rest-nvim / rest.nvim

A fast Neovim http client written in Lua
GNU General Public License v3.0
1.61k stars 142 forks source link

add telescope extension to select env file #278

Closed BingCoke closed 9 months ago

NTBBloodbath commented 9 months ago

Hey, the truth is I never expected someone to do something like this and I love the idea, thank you very much!

I'm currently rewriting the entire plugin and I'd like this to be in the dev branch to include in the next version.

Also I saw this PR and decided to expose a function ("rest-nvim.functions").find_env_files() in the rewrite branch which I think could be very useful and would reduce the telescope extension code, also removing the optional dependency on fd :)

BingCoke commented 9 months ago

Hey, the truth is I never expected someone to do something like this and I love the idea, thank you very much!嘿,事实是我从没想过有人会做这样的事情,我喜欢这个主意,非常感谢!

I'm currently rewriting the entire plugin and I'd like this to be in the dev branch to include in the next version.

Also I saw this PR and decided to expose a function ("rest-nvim.functions").find_env_files() in the rewrite branch which I think could be very useful and would reduce the telescope extension code, also removing the optional dependency on fd :)

Thanks you love this! By the way fd is telescope's dependency so no need to remove it.

BingCoke commented 9 months ago

I think it could be better used as a extension as other plugin like project.nvim so that optional to load it. I also want to add other feature like

  1. add lualine source, when we in http file we can check what env we select and add EditEnv command to edit current env file
  2. add http file snippets
  3. add attach function (you know there is not a http lsp) we can keybinding just in http file

Do you think these features could be added to this repository?

NTBBloodbath commented 9 months ago

Woops, I just woke up and have some time to look at GitHub.

Of course, why not? Those ideas sound super useful, I will be happy to have them in the repository :p

Otard95 commented 9 months ago

This can be fairly easily accomplished in your own dotfiles as well. Here's my config for rest.nvim, hope it helps someone.

BingCoke commented 9 months ago

This can be fairly easily accomplished in your own dotfiles as well. Here's my config for rest.nvim, hope it helps someone.

yes of course,but i think it could be better be managed by this repo other than user's config.

Otard95 commented 9 months ago

yes of course,but i think it could be better be managed by this repo other than user's config.

I didn't mean to imply that it shouldn't, sorry if it came across that way. Only wanted to give an option to anyone else coming along in the mean time 😊

NTBBloodbath commented 9 months ago

Sorry it took so long for me to merge this. I've been somewhat busy with other projects and the rest.nvim incoming version is also a priority, I'll make sure to cherry-pick this and the lualine features into the dev branch, thank you so much :)