search

rest-nvim / rest.nvim

A fast Neovim http client written in Lua
GNU General Public License v3.0
1.35k stars 117 forks source link

Feature Request: Notifications #381

Open kevintraver opened 1 month ago

kevintraver commented 1 month ago

Feature Request:

Use vim.notify on request start and request completed, or if there is an error.

Could be an opt-in feature.

Happy to help with a PR.

Thanks for the awesome plugin!

NTBBloodbath commented 1 month ago

Hey!

Currently I have many things on my list, unfortunately I am in exam weeks and I have not been able to do any of the project yet. I would gladly accept a PR for this, sounds really useful :)

Ps: personally I would make it opt-out instead, as receiving a notification in Neovim isn't an obtrusive thing and it could come handy to have it by default. Perhaps you could use a fidget implementation instead like what rocks.nvim does?

teto commented 1 month ago

in v1 we had a system of hooks just for this purpose. If it is still available in latest version, I would recommand to look into it so you dont need upstreaming. I would also suggesto add a threshold: if the request is instant, no need for notifs