search

restarone / violet_rails

an app engine for your business. Seamlessly implement business logic with a powerful API. Out of the box CMS, blog, forum and email functionality. Developer friendly & easily extendable for your next SaaS/XaaS project. Built with Rails 6, Devise, Sidekiq & PostgreSQL
https://violet.restarone.solutions
MIT License
95 stars 43 forks source link

API action workflow email action text area overflow #872

Closed donrestarone closed 2 years ago

donrestarone commented 2 years ago

Describe the bug

Text does not show correctly on the vertical axis

Screen Shot 2022-07-04 at 2 27 10 PM

To Reproduce Steps to reproduce the behavior:

  1. Go to an API Namespace (if you don't have one, create one by visiting API)
  2. Click on Action Workflow
  3. Create an Email action
  4. notice that the text field does not expand as the user types

Expected behavior

rich text area should expand

Ayon95 commented 2 years ago

The overflow is not happening on my machine. Capture

donrestarone commented 2 years ago

@Ayon95 I don't think you are replicating the issue correctly. Please also specify where you are testing (eg; Firefox on windows 10)

note the issue here: https://github.com/restarone/violet_rails/issues/872#issue-1293472425 the problem arises when you add vertical text-- not horizontal text (again, see illustration above)

Ayon95 commented 2 years ago

Oh I see. I tested it with vertical text, and yes it is overflowing. The reason is that Bootstrap classes like form-control enforce a fixed height. It can be fixed by setting the height of the rich text area to auto.

Tested on Chrome Windows 10.

donrestarone commented 2 years ago

@Ayon95 thanks! if you have the bandwidth, please feel free to submit a PR with a fix 🙏

Ayon95 commented 2 years ago

All right, I'll submit a PR with the fix later today.