search

restarone / violet_rails_ios_client

0 stars 3 forks source link

Add multi app support (#20) #21

Closed donrestarone closed 1 year ago

donrestarone commented 1 year ago
donrestarone commented 1 year ago

@josessolmaximo This is coming together well!

Here are some issues that need to solved (please push/use this branch for the fixes)

1. when a subdomain path is passed, it is not rendered:

Screen Shot 2023-05-06 at 9 37 47 AM Screen Shot 2023-05-06 at 9 32 46 AM Screen Shot 2023-05-06 at 9 32 37 AM

we should allow for this use case, where the root app returns a list of relative and "fully qualified" endpoints (with a full subdomain, domain + path)

2. Blog is not being rehydrated between Violet Apps

https://user-images.githubusercontent.com/35935196/236627788-e896e212-2e47-4888-9f38-5c2ac73b19a9.MP4

You can reproduce both issues by adding https://restarone.com to your Violet iOS App

josessolmaximo commented 1 year ago

@donrestarone I have fixed these issues, but I need a personal access token in order to push to this branch

donrestarone commented 1 year ago

@josessolmaximo Ah, not sure why that is. Let's figure it out later, in the meantime-- could you open a PR against this branch so we could merge the fixes?