restatedev / cdk

MIT License
5 stars 4 forks source link

Ensure discovery is called on EC2 configuration changes (e.g. IP address); alternatively, enable termination protection #4

Closed pcholakov closed 11 months ago

pcholakov commented 11 months ago

Actually I think this is redundant; since the EC2 instance private IP address is wired into the registration resource, this should absolutely happen if the EC2 instance is replaced during a CloudFormation deployment. It will not happen if the EC2 instance is replaced outside of a CloudFormation/CDK deployment but that's ok; that should happen only in extreme circumstances when AWS irrecoverably loses the customer instance, which is beyond the scope of this basic stack.