search

restatedev / examples

Restate examples
https://restate.dev
MIT License
45 stars 9 forks source link

Simplify CDK templates and avoid VPC lookups during synth step #170

Closed pcholakov closed 3 months ago

pcholakov commented 3 months ago

With this PR, we're making sure that any test failing causes the entire GitHub workflow to fail fast. Previously, intermediate build failures were not causing the action to report an error.

Secondly, the CDK examples are updated so that they can build on GH without AWS creds; this also serves to make the more general and leaves it up to the user to decide whether to deploy to EC2 (commented out) or target an existing Restate server (either externally managed, or a Restate Cloud environment).

Ideally we should be testing the bun/deno/cloudflare templates with their respective deployment tools but that's outside of the scope of the current PR. I'll submit a separate change to include those in the test checks.

pcholakov commented 3 months ago

You're too quick! ;-) Indeed it does, and that was the intended result! @gvdongen pointed out that the cdk synth test in the Lambda/CDK samples has been quietly failing - I wanted to make sure that the workflow fails before merging the fix.