github-actions[bot]
commented
1 month ago Test Results
15 files - 33 15 suites - 33 10s :stopwatch: - 2m 57s 664 tests - 74 657 :white_check_mark: - 72 7 :zzz: - 2 0 :x: ±0 665 runs - 74 658 :white_check_mark: - 72 7 :zzz: - 2 0 :x: ±0
Results for commit 3c1eb3f0. ± Comparison against base commit 2b5d8e42.
This pull request removes 109 and adds 35 tests. Note that renamed tests count towards both.
``` dev.restate.e2e.JavaAwaitTimeoutTest ‑ Test Awaitable#await(Duration) dev.restate.e2e.JavaAwakeableTest ‑ generate(IngressClient) dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on AWAKEABLE dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on CALL dev.restate.e2e.JavaCancelInvocationTest ‑ cancel blocked invocation on SLEEP dev.restate.e2e.JavaCoordinatorWithNodeReceiverServiceToServiceCallTest ‑ synchronousCall(IngressClient) dev.restate.e2e.JavaErrorsTest ‑ Test calling method that fails terminally dev.restate.e2e.JavaErrorsTest ‑ Test calling method that fails terminally multiple times dev.restate.e2e.JavaErrorsTest ‑ Test invocations are retried until they succeed dev.restate.e2e.JavaErrorsTest ‑ Test propagate failure from another service … ``` ``` dev.restate.sdk.common.SerdeTest ‑ Null: null dev.restate.sdk.common.SerdeTest ‑ byte[]: [B@67545b57 dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Boolean: false dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Boolean: true dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Byte: -128 dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Byte: 127 dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Byte: 59 dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Double: 0.28978800258291215 dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Double: 1.7976931348623157E308 dev.restate.sdk.serde.jackson.JsonCoreSerdeTest ‑ Double: 4.9E-324 … ```:recycle: This comment has been updated with latest results.
Moved the
JSON_Serdes to JacksonSerdes, now renamedJsonSerdes. This partially removes the requirement for us to retain the jackson-core dependency on sdk-common, but it requires the user to bring in the serde jackson module also for primitive types.After that I only need https://github.com/restatedev/sdk-java/issues/323 and I can remove the jackson dependency from sdk-common, and shade the jackson-databind dependency i need only in the core.