restatedev / sdk-typescript

Restate SDK for JavaScript/Typescript
MIT License
46 stars 8 forks source link

Normalise incoming paths before checking them against signature #434

Closed jackkleeman closed 1 week ago

jackkleeman commented 1 week ago

THe runtime does not absolutise its paths against the http url - it just signs something like /invoke/a/b or /discover. We should normalise the paths we receive when checking against the signature.

github-actions[bot] commented 1 week ago

Test Results

15 files  +10  15 suites  +10   17m 57s :stopwatch: + 15m 27s  6 tests  - 36   6 :white_check_mark:  - 36  0 :zzz: ±0  0 :x: ±0  18 runs   - 86  18 :white_check_mark:  - 86  0 :zzz: ±0  0 :x: ±0 

Results for commit 83e61005. ± Comparison against base commit 479936f4.

This pull request removes 42 and adds 6 tests. Note that renamed tests count towards both. ``` dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client) dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[1] dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[2] dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[3] dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[1] dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[2] dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[3] dev.restate.sdktesting.tests.Ingress ‑ headersPassThrough(Client) dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeSend(Client) dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeService(Client) … ``` ``` dev.restate.e2e.JavaAwakeableTest ‑ generate(Client) dev.restate.e2e.KtInterpreterTest ‑ simple(int) dev.restate.e2e.NodeAwakeableTest ‑ generate(Client) dev.restate.e2e.NodeInterpreterTest ‑ simple(int) dev.restate.e2e.RetryOnUnknownServiceTest ‑ retryOnUnknownServiceUsingCall(Client, URL) dev.restate.e2e.RetryOnUnknownServiceTest ‑ retryOnUnknownServiceUsingOneWayCall(Client, URL) ```

:recycle: This comment has been updated with latest results.